-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New transformer #238
New transformer #238
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey nice PR @Boorinio! I'm struggling to think of the use cases for this Transformer though. Can you help me?
WordOrderRandomizer is now compatible with all datasets.
Hey, thanks for the reply! |
This transformer will make sense when we have RNNs. For the bag-of-words classifiers available, it will not make much sense. Care to @Boorinio what was the classifier you were using this transformer with? |
I'm struggling to think of use cases for this. Maybe they will become more apparent in the future but as for now I think we should put this in the Extras package. @Boorinio would you mind submitting a PR to Extras repo? |
Hey thanks for the responses and sorry for the big delay, closing this one! |
Hello,
This is my first pr and I want to start off by saying I am really happy I discovered this project!
This pr includes a small fix for the text normalize class which according to the docs should be categorical. Also it includes a new transformer that shuffles a given string's words. I used the transformer in a personal project and it is useful for cases where the order of the words is not important (Product titles that need to be classified into categories).
Have a nice day, I hope this helps!