Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 7 #872

Closed
wants to merge 30 commits into from
Closed

Version 7 #872

wants to merge 30 commits into from

Conversation

antstorm
Copy link
Contributor

@antstorm antstorm commented Jun 12, 2019 •
edited
Loading

This PR is for tracking progress on releasing version 7.

This release comes with a couple of breaking changes:

  • Dropping support for older rubies (< 2.3)
  • .eql? no longer returns true when comparing different currency money object
  • Removing all the deprecated formatting options
  • Changing default locale backend to :currency
  • Changing default currency to nil
  • Changing default rounding mode to ROUND_HALF_UP

Here's the list of outstanding tasks for the release:

  • Update README to reflect all the changes
  • Mention all the breaking changes in the README
  • Add a post_install message linking to the new section in README
  • Loose I18n dependency
  • Fix rbx specs
  • Change the default locale_backend to nil
  • Raise error when initializing Money without a currency and no default set

@antstorm antstorm added the ver:7 label Jun 12, 2019
@antstorm antstorm mentioned this pull request Jun 12, 2019
Closed
@coveralls
Copy link

coveralls commented Jun 12, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 99.815% when pulling 048f70b on v7_new into 3e14ac4 on master.

@antstorm antstorm mentioned this pull request Oct 16, 2019
Closed
@antstorm antstorm added this to the Version 7 milestone May 16, 2020
orien and others added 22 commits July 4, 2020 22:25
@orien @antstorm
eql? returns false for 0 value moneys of differing currency
b7ad0f5
@antstorm
Drop support of older rubies (< 2.3)
44be5d4
@AlexWayfer @antstorm
Add R18n locale backend (#789)
7343814 
https://github.com/ai/r18n
@antstorm
Remove :symbol_before_without_space formatting option
d973657 
This is fully replaced with :format option
@antstorm
Remove :symbol_after_without_space formatting option
d86272f 
This is fully replaced by :format option
@antstorm
Remove :symbol_position formatting option
5508ee5 
This is fully replaced by :format option
@antstorm
Remove deprecated #currency_as_string and #currency_as_string=
a6b8d34
@antstorm
Remove deprecated :html and :html_wrap_symbol formatting options
dc42f1f 
Use :html_wrap instead
@antstorm
Remove use_i18n option (#818)
14cfea6 
Money.locale_backend = :i18n should be used instead
@antstorm
Remove Heuristics module
c45fb0e
@antstorm
Remove legacy locale backend
2a9e3bd
@antstorm
Remove old formatting rules format
61e057d
@antstorm
Loose i18n dependency
02c5c26
@antstorm
Add Anthony as one of the authors
19667fe
@antstorm
Localize format: option (#825)
237d0c2
@printercu @antstorm
Siplified arithmetic_spec
75f8de0
@thealiilman @antstorm
Change Money.default_currency to nil (#868)
cb9ced6
@antstorm
Switch default rounding mode from ROUND_HALF_EVEN to ROUND_HALF_UP (#863
fa03b09 
)

* Switch default rounding mode to ROUND_HALF_UP

* Update references to the former default rounding mode
@antstorm
Remove ability to call Money#rounding_mode with a block (#875)
b4b5d0f
@antstorm
Remove legacy version locks (#876)
4133bcc 
* Remove version locks for ruby < 2.3

* Drop jruby 9.0.x (ruby 2.2 equivalent) support
@antstorm
Make I18n dependency optional (#877)
ce62c3d
@antstorm
Exclude i18n specs from rbx suite (#878)
dd12f29 
* Allow running specs without I18n

* Exclude i18n specs from rbx

* Disallow rbx failures
@deepakhb2
Replace "symbol_first" with "format" for currency definitions (#944)
aac5ec0 
* Make spacing part of currency rules when symbol proceed the ammount

* Add :symbol_with_space attribute to CHF currency in currency config
  file.
* Initialize symbol_with_space instance variable for currency objecti
  with default value false.
* Set '%u %n' format in rules if symbol_with_space value is true for a
  currency
* Add test cases to cover the change.

* Depricating symbol_first and symbol_with_space options.

* Cofigure format attribute to define formating rule for a currency.
* Initialize and use format to format symbol and value of a currency.
* Remove symbol_first and symbol_with_space related code.

* Replace symbol_first attribute with format in spec files.
@deepakhb2
Raise exception when default currency is not set or passed as paramet…
7c64da7 
…er (#950)

* Raise expception when default currency is not set or passed as parameter

* Raise DefaultCurrencyNotSetOrPassed exception.
* After checking default currency this exception is raised.

* Raise the exception in initializer.

* Fix all the test cases by passing currency.
Left few test cases to get clarification.

* Fix the tests and add test case to test DefaultCurrencyNotSet exception.
@semmons99 semmons99 closed this Feb 27, 2021
@AlexWayfer
Copy link
Contributor

@semmons99 closed this 8 days ago

Why?!

@semmons99
Copy link
Member

had not been touched in nearly six months. we prefer not to leave dormant branches. if someone wants to take this over the finish line, happy to see it reopened.

@AlexWayfer
Copy link
Contributor

had not been touched in nearly six months. we prefer not to leave dormant branches. if someone wants to take this over the finish line, happy to see it reopened.

Maybe I'm ready to, but I need a time to investigate changes. The main person with which I was involved is @antstorm, is they OK?

@antstorm
Copy link
Contributor Author

antstorm commented Mar 6, 2021

@AlexWayfer hey, all good, just very short on time. I'll start splitting these commits one into smaller PRs. Too much was packed into a single release here

@AlexWayfer
Copy link
Contributor

@AlexWayfer hey, all good, just very short on time. I'll start splitting these commits one into smaller PRs. Too much was packed into a single release here

OK, thank you, I'll try to watch them!

@MorneL
Copy link

MorneL commented Jan 25, 2022

@antstorm @semmons99 what ended up happening with this release? We'd love to have the functionality to change format: '%n %u' per locale. Are there any stable releases including this change?

@semmons99
Copy link
Member

no one went back and took ownership to make this reviewable and shippable. you are welcome to extract the key piece you desire and submit it as a PR that can be reviewed, merged, and shipped independently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ver:7
Projects
None yet
Milestone
Version 7
Development

Successfully merging this pull request may close these issues.
10 participants
@antstorm @coveralls @AlexWayfer @semmons99 @MorneL @orien @printercu @thealiilman @janklimo @deepakhb2