Skip to content

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Jun 7, 2023

No description provided.

Copy link
Contributor

@vsreekanti vsreekanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Few tiny nits in line.

artifacts.md Outdated


## Disabling Snapshots on Artifacts
By default, Aqueduct snapshots all artifact results during workflow runs. You can change this setting when [publishing the workflow](./workflows/creating-a-workflow.md), or call `.disable_snapshot()` or `.enable_snapshot()` on individual artifacts. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: " when publishing the workflow by setting the disable_snapshots flag to True. You can also call .disable_snapshot():"

Then after the code snippet, add:

On an artifact that has had snapshotting disabled, you can call enable_snapshot() to reenable snapshots.

@@ -88,6 +88,7 @@ There are a few key arguments here, and we'll go through the one by one:
* You're, of course, welcome to list out all of the data artifacts in your workflow, but we figured it would be easier to list the outputs you care about.
* `schedule`: This tells us how often you'd like to run your workflow. If you leave this empty, no schedule will be set, and you can set a schedule that executes as quickly as every minute or as rarely as every month. (See [managing-workflow-schedules.md](managing-workflow-schedules.md "mention") for more details.)
* `config`: This tells us which connected engine you'd like to run your workflow. If you leave this empty, the workflow will be executed by Aqueduct engine by default. We currently support Airflow, Kubernetes, and Lambda.
* `disable_snapshots`: This tells us if we should store snapshots of intermediate results. This disables all snapshots NOT coming from parameters, metrics, or checks. Additionally, you can alternate this behavior on individual [artifacts](../artifacts.md) by calling `.disable_snapshot()` on the artifact.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables all snapshots except for parameter, metrics, or checks.

Instead of "alternate", let's use "toggle".

@@ -6,7 +6,7 @@ Workflows are versioned on every execution. You can see previous versions on by

On every execution, Aqueduct automatically captures the code that was executed as well as _all the data that was generated by the workflow_ -- this includes intermediary data artifacts that aren't explicitly saved by the workflow. Aqueduct captures this information on each workflow run in order to help debug workflows, both within an individual execution and across time. 

By default, the snapshots of intermediary data are stored on your local filesystem. **NOTE**: We are working on making this feature configurable.
By default, the snapshots of intermediary data are stored on your local filesystem. You can alternate this settings when publishing the workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternate -> toggle

Copy link
Contributor

@vsreekanti vsreekanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Few tiny nits in line.

@likawind likawind merged commit 1c82242 into main Jun 7, 2023
@likawind
Copy link
Contributor Author

likawind commented Jun 7, 2023

GH failure due to server mismatch during release, confirmed low risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants