-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Add Flux RPC. #1365
Merged
Merged
Feature - Add Flux RPC. #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of changes, will review/merge after tomorrow release :) |
5de00fb
to
4df11df
Compare
Cabecinha84
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from the
feature/zmq_enable
branch. So that branch getting merged into develop is a dependency for this branch.#1363
(It will look a lot smaller once that branch is merged)
What this pull does
bitcoin
packagedaemonrpc
inline package that was reliant on bitcoindaemonRpcUtils
to use asyncLock and small tidy upFluxRpc
Much simpler, and leverages existingaxios
AsyncLock
You can now await ready with a timeout, or await and disable with timeout.The main reason I needed this was so I can pass a
signal
into the rpc to cancel it, when necessary. It can take approx 500ms to pull the determ node list, if a block comes in when we are in the middle of this, it makes sense to cancel the pending request and start another.It was also good to get rid of another couple of dependencies in
package.json