Feature - update myApps page (vue) #1371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy for this pull to wait a while, quite a few changes in the current release. I may have got carried away on this one, was originally just to fix the map bug that slipped through in the last release.
What this pull does
myApps
to separate components. TheMyAppsTab
component could be composed further, this is just a start.My Active Apps
andMy Expired Apps
pages so they are visually the same. This removes about 600 lines of code as we can reuse the same component for both.Screenshots:
Prior "My Expired Apps":
New "My Expired Apps":
Adds the per page and filter features, adds the app count, and adds the application expired notifier
Prior "My Active Apps":
New "My Active Apps":
Updates the page count label to be the same size
Prior Logged out view:
New Logged out view: