Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.19.0 #1380

Merged
merged 15 commits into from
Jul 30, 2024
Merged

v5.19.0 #1380

merged 15 commits into from
Jul 30, 2024

Conversation

Cabecinha84
Copy link
Member

  • Improvements on UI getting live response from backend;
  • Get information on home UI if node is not daemon synced;
  • Improvements on primary/standby apps checks;
  • Other small improvements.

Copy link

gitguardian bot commented Jul 30, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8398280 Triggered PGP Private Key 87861a7 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 87861a7 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 678607b HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 678607b HomeUI/dist/js/index.js View secret
13002733 Triggered Generic Password 678607b HomeUI/dist/js/2532.js View secret
13011717 Triggered Generic Password 678607b HomeUI/dist/js/2532.js View secret
13011718 Triggered Generic Password 678607b HomeUI/dist/js/2532.js View secret
13011719 Triggered Generic Password 678607b HomeUI/dist/js/2532.js View secret
13011720 Triggered Generic Password 678607b HomeUI/dist/js/2532.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@TheTrunk TheTrunk merged commit bf5252b into master Jul 30, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants