Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Unhandled DNS lookup error and image parsing #1383

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

MorningLightMountain713
Copy link
Contributor

Note: Have added the Titan link back that I mistakenly thought was no longer used. (Will fix console error this is creating in a future pull)

Two things going on here.

First, the image parsing was missing a return statement if no match at all was made (edge case), which somehow allowed for an image starting with a / to be accepted. I'm not sure how this app even got registered, as I tested it on the home.runonflux.io register page, and it throws an error.

I will add some tests in for this tomorrow.

Second, when FluxOS goes to remove the app (the image doesn't exist) it's causing a dns lookup to fail somewhere for the hostname "images" I can't track this down at the moment, so have put a hack in place so we catch this error globally, and continue on.

With patch:

Uncaught DNS Lookup Error!!, swallowing.
Error: cacheableLookup ENOTFOUND images
    at CacheableLookup.lookupAsync (file:///home/davew/zelflux/node_modules/cacheable-lookup/source/index.js:202:18) {
code: 'ENOTFOUND',
hostname: 'images'
}

It has to be one of the axios calls as that is the only thing using cacheable lookups. I will try find this tomorrow - I can replicate the error by putting this blob back in the db:

  {
    name: 'gridprueba',
    compose: [
      {
        name: 'Webserver',
        description: 'grid',
        repotag: '/nginx:latest',
        ports: [ 34349 ],
        domains: [ '' ],
        environmentParameters: [],
        commands: [],
        containerPorts: [ 80 ],
        containerData: '/tmp',
        cpu: 0.5,
        ram: 500,
        hdd: 15,
        tiered: false,
        secrets: '',
        repoauth: ''
      }
    ],
    contacts: [],
    description: 'asd',
    expire: 5000,
    geolocation: [],
    hash: '6718b5e140301c815ef2f8f0fec1a6ad8fa853f68b85a69828cfaa8f75470910',
    height: 1702605,
    instances: 3,
    nodes: [],
    owner: '1Ltfpyy1PuUuqaX8QT59nZ6UD2WURedBSF',
    staticip: false,
    version: 7
  }

@TheTrunk TheTrunk merged commit bad529e into development Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants