Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.23.0 #1394

Merged
merged 34 commits into from
Aug 27, 2024
Merged

v5.23.0 #1394

merged 34 commits into from
Aug 27, 2024

Conversation

Cabecinha84
Copy link
Member

@Cabecinha84 Cabecinha84 commented Aug 27, 2024

  • api '/apps/calculatefiatandfluxprice' will now return 0 USD/Flux price for app updates that will be offered by the network;
  • api '/apps/calculateprice' now returns the same as the above api and in the next few months will be removed as it is already classified as deprecated for some time;
  • Improvements on primary/stand by solution;
  • Other small improvements on UI;

@Cabecinha84 Cabecinha84 requested a review from alihm August 27, 2024 12:00
Copy link

gitguardian bot commented Aug 27, 2024

⚠️ GitGuardian has uncovered 14 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8398280 Triggered PGP Private Key 8e9ec0a HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key ce935a4 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 5411975 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 1967ddf HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key f960d8c HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 09c479d HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 1967ddf HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 243e37e HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key ce935a4 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 5411975 HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 243e37e HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 09c479d HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key 8e9ec0a HomeUI/dist/js/index.js View secret
8398280 Triggered PGP Private Key f960d8c HomeUI/dist/js/index.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Cabecinha84 Cabecinha84 requested a review from sygem August 27, 2024 15:00
@TheTrunk TheTrunk merged commit a9ef5f9 into master Aug 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants