Redesign spirv-builder's watch API
#422
Open
+176
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2025
tuguzT
force-pushed
the
spirv-builder-watch-channel
branch
2 times, most recently
from
5037f91 to
66a5c6b
Compare
tuguzT
force-pushed
the
spirv-builder-watch-channel
branch
from
66a5c6b to
f241062
Compare
|
I thought CI issues were already resolved at GitHub side? |
tuguzT
requested review from
eddyb,
LegNeato,
Firestar99 and
schell
as code owners
Firestar99
force-pushed
the
spirv-builder-watch-channel
branch
from
e5e56df to
f956b84
Compare
Firestar99
reviewed
Oct 2, 2025
There was a problem hiding this comment.
I love the new design!
Just iterated some more on it, so I'll let others do the reviewing
My changes to it:
- we can just consume SpirvBuilder, if users need to clone it they can
- changing a file during recompilation no longer throws errors in stdout but will trigger exactly one recompile when you call
recv()again - wgpu example had a race condition between the first and watched compiles
Firestar99
force-pushed
the
spirv-builder-watch-channel
branch
from
4a9a64c to
aefe49e
Compare
|
I added a non-blocking |
Firestar99
force-pushed
the
spirv-builder-watch-channel
branch
from
aefe49e to
13a80b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was suggested to rewrite API from scratch instead of patching the existing one.
My idea now is to expose refactored
Watcher, which could just returnCompileResultonrecv(), then we don't need to accept any callbacks, differentiate first compile result from others, etc.