CI: move to containers & cleanups #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `bash` and other shells support it, `dash` (`/bin/sh` in Ubuntu) does not, and it is better to avoid Bash-dependent behaviors anyway. In particular, GitHub Actions, when using a container, does not attempt to force `bash`, thus we can simply use `dash` instead. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
It is useful to know what was the final configuration used. We could use `upload-artifact`, but that was flaky in the past for us, (and there does not seem to be a way to ignore errors yet). Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This allows us to use different (and in particular, newer) Ubuntu images, it is easier to move it to another CI and to use it locally by others. This, in turn, gives us easy access to e.g. newer GCCs like 11.2 which may spot other issues, like the one by the Intel CI the other day (which I wanted to reproduce in the CI -- this commit includes enabling the config option that triggered it). It also allows us to drop `ci-bin`, since we get QEMU 6.0 from Ubuntu and we can compile BusyBox too. It should also avoid most networking issues since we rely only on content from GitHub. Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use different (and in particular, newer) Ubuntu images,
it is easier to move it to another CI and to use it locally by others.
This, in turn, gives us easy access to e.g. newer GCCs like 11.2 which may
spot other issues, like the one by the Intel CI the other day (which
I wanted to reproduce in the CI -- this PR includes enabling the config option
that triggered it).
It also allows us to drop
ci-bin, since we get QEMU 6.0 from Ubuntuand we can compile BusyBox too.
It should also avoid most networking issues since we rely only on content
from GitHub.
Also contains a few other fixes.