Pass Header to DecodeValue
#392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to implement `DecodeValue` for tagless types such as `CHOICE` and `ANY`. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
This certainly does help address a few use cases.
I'm a bit worried in that it has a sharp edge in regard to context-specific IMPLICIT productions: anything which attempts to introspect on the tag will encounter the context-specific tag in that case in lieu of e.g. a universal tag they might be expecting.
It might be good to document that in the rustdoc for DecodeValue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to implement
DecodeValuefor tagless types suchas
CHOICEandANY.Signed-off-by: Nathaniel McCallum nathaniel@profian.com