Switch from sha-1 to sha1 #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
newpavlov-patch-1
branch
2 times, most recently
from
adb80e3 to
e33e4f7
Compare
newpavlov
force-pushed
the
newpavlov-patch-1
branch
from
e33e4f7 to
7fe9af9
Compare
tarcieri
reviewed
Feb 12, 2022
|
|
||
| ## [UNRELEASED] | ||
| ### Changed | ||
| - `sha1` feature is renamed to `sha1-insecure` ([#426]) |
tarcieri
approved these changes
Feb 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha-1will be eventually deprecated in favor ofsha1, so it's worth to migrate to it beforehand.On stable you can not write
sha1 = ["pbes2"], whensha1is an optional dependency. We could rename thesha1dependency, but I think renaming the feature is a slightly better option.