-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIPEMD-256 implementation #278
Conversation
@gavadinov great! I'll take a look when I have some time to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gavadinov looks good!
I see you've already published the crate. Would you still like to upstream it here?
hey @tarcieri, thank you for the review. Yeah I had to publish it because I needed to use it. I would be happy to move it here and to change the ownership of the crate on crates.io. |
@gavadinov fantastic. Does the code in this PR reflect what's published in the crate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good (although I did only a cursory review), so think we can merge and publish it. But note that later we probably will merge the 3 ripemd crates into a single ripemd
crate.
Yep it is the same. Here is the original - https://github.com/gavadinov/ripemd256
Yeah that makes sense. There is quite a lot of duplication between the crates. |
@gavadinov cool, can you add us as owners of the |
Done Also I noticed a typo in the keywords 🙈 - #296 |
Thank you! |
Partially addresses #1
A RIPEMD-256 implementation based on the existing RIPEMD-320 implementation and https://android.googlesource.com/kernel/common/+/07e6124a1a46/crypto/rmd256.c.
The test values come from - https://homes.esat.kuleuven.be/~bosselae/ripemd160.html