crypto-bigint: Integer trait
#612
Conversation
tarcieri
force-pushed
the
crypto-bigint/integer-trait
branch
2 times, most recently
from
c822a1a to
7265346
Compare
| use rand_core::{CryptoRng, RngCore}; | ||
|
|
||
| /// Integer type. | ||
| pub trait Integer: |
There was a problem hiding this comment.
why no requirements for Add, Mul etc?
There was a problem hiding this comment.
Those traits are presently only impl'd for Wrapping<UInt<_>> in order to be explicit about the wrapping vs checked behavior.
However, it would be possible to bound on Wrapping<Self> impl'ing them.
There was a problem hiding this comment.
FWIW, in elliptic-curve I end up bounding on the modular arithmetic traits: https://github.com/RustCrypto/traits/pull/732/files#diff-58bf09549ae77b47fcc1f18c3335fd0f6a4eb49a1e3cee51332fe40dcfd66daaR113-R120
type UInt: bigint::AddMod<Output = Self::UInt>
+ bigint::Integer
+ bigint::NegMod<Output = Self::UInt>
+ bigint::Random
+ bigint::RandomMod
+ bigint::SubMod<Output = Self::UInt>
+ zeroize::Zeroize;They could potentially be included in the Integer bounds.
There was a problem hiding this comment.
I guess I didn't add bounds on *Mod initially because they are only impl'd for a subset of the supported integer values
There was a problem hiding this comment.
Yeah makes sens to wait for adding those bound, until we have a more complete set
tarcieri
force-pushed
the
crypto-bigint/integer-trait
branch
from
7265346 to
4546f0f
Compare
Adds a trait encompassing the interesting bounds of `UInt`. Since traits like `elliptic_curve::Curve` can't yet be generic over `const LIMBS`, this trait provides a convenient way of wrapping up `UInt` behavior such that it's still usable without spelling out all of these bounds explicitly.
tarcieri
force-pushed
the
crypto-bigint/integer-trait
branch
from
4546f0f to
7b6aca1
Compare
tarcieri
changed the title
Integer traitInteger trait
2 participants
Adds a trait encompassing the interesting bounds of
UInt.Since traits like
elliptic_curve::Curvecan't yet be generic overconst LIMBS, this trait provides a convenient way of wrapping upUIntbehavior such that it's still usable without spelling out all of these bounds explicitly.