-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implimenting os ctermid #2401
base: main
Are you sure you want to change the base?
Implimenting os ctermid #2401
Conversation
Hey @coolreader18 could you please let me know if my approach is right? |
It doesn't look like libc has ctermid -- rust-lang/libc#1928. However, you can just define it inline, as:
Also, you have to pass |
aec87be
to
7f6e5a8
Compare
should I inline it within the function itself or is it ok as is? |
6bf2f0f
to
829b892
Compare
711e4ca
to
41a680d
Compare
I checked macos python 3.9 and linux 3.6 but cannot find |
I dont really understand you comment :/ maybe please explain a little more? If you were referring to the function name, it was indeed named |
I expect this PR has just 1 commit. Any PR shouldn't contain a merge commit. Rebase or cherry-pick your work onto upstream/master please. |
62a5caf
to
c057f5e
Compare
Note for the reviewers: i saw another pr(#3017) for fcdir so removed the code here |
c057f5e
to
ee19708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no #[pyfunction]
means never tested
Description
ctermid
first - so that i can try to understand the rust python compiler