Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for RxSwift 6.0.0 #54

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Support for RxSwift 6.0.0 #54

merged 2 commits into from
Jan 5, 2021

Conversation

vandadnp
Copy link
Contributor

@vandadnp vandadnp commented Jan 5, 2021

  1. update RxSwift and RxCocoa versions in the podspec to 6.0.0
  2. change directory from RxCoreDateExamples to RxCoreDataExamples (note Date vs Data)
  3. ensure there is a Podfile for the examples
  4. add the necessary pods to the Podfile for the examples
  5. ensure the Examples projects builds and remove all errors

@vandadnp
1) update RxSwift and RxCocoa versions in the podspec to 6.0.0
c03227c 
2) change directory from RxCoreDateExamples to RxCoreDataExamples (note Date vs Data)
3) ensure there is a Podfile for the examples
4) add the necessary pods to the Podfile for the examples
5) ensure the Examples projects builds and remove all errors
@vandadnp vandadnp mentioned this pull request Jan 5, 2021
Closed
@vandadnp
Copy link
Contributor Author

vandadnp commented Jan 5, 2021

@bobgodwinx could you look at this please? 🙏

@bobgodwinx
Copy link
Member

Looks nice 👍🏾 Thanks very much.

@bobgodwinx bobgodwinx merged commit 5111446 into RxSwiftCommunity:master Jan 5, 2021
@rxswiftcommunity
Copy link

Thanks a lot for contributing @vandadnp! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@vandadnp
Copy link
Contributor Author

vandadnp commented Jan 5, 2021

@bobgodwinx thank you very much 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandadnp @bobgodwinx