Skip to content

Conversation

Troon
Copy link
Contributor

@Troon Troon commented Oct 2, 2025

Replaces the deprecated object_id (slug) with default_entity_id (domain.slug) in the Home Assistant auto-discovery config.

Troon added 2 commits October 2, 2025 09:48
object_id becomes default_entity_id
Update discovery.py for latest HA AD
@Troon
Copy link
Contributor Author

Troon commented Oct 2, 2025

This is the HA PR that made the change. Documentation seems not to have caught up at this stage.

@nanomad
Copy link
Contributor

nanomad commented Oct 3, 2025

That's just great from HA side.... should we keep the old object_id for backwards compatibilty? It seems like the change hasn't landed for 2025.10 and I don't want to break everything

edit: just saw the log myself, I have no telemetry on how many people are on 2025.9 or oder still. Since the support for object_id will go away in 2026.4 I suggest we keep them both

@Troon
Copy link
Contributor Author

Troon commented Oct 3, 2025

That's just great from HA side.... should we keep the old object_id for backwards compatibilty? It seems like the change hasn't landed for 2025.10 and I don't want to break everything

Probably a good idea for those running older versions. Just leave the old line in the code as well at line 1051. Not sure how to update a PR without causing a lot of noise...

UPDATE: just added that line back in and reloaded everything: no problems or warnings with latest 2025.10 HA.

@nanomad
Copy link
Contributor

nanomad commented Oct 3, 2025

@Troon you can just push a new commit on your branch that adds that key back, no noise is generated and helps follow up the rationale behind code changes :)

for backwards compatibility
Copy link
Contributor Author

@Troon Troon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added object_id back in for backwards compatibility

nanomad
nanomad previously approved these changes Oct 4, 2025
@nanomad nanomad changed the base branch from main to develop October 4, 2025 10:55
@nanomad nanomad dismissed their stale review October 4, 2025 10:55

The base branch was changed.

@nanomad nanomad merged commit 20a8baa into SAIC-iSmart-API:develop Oct 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants