SapMachine (17) #1550: New malloc trace implementation #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
RealCLanger
changed the title
reinrich
reviewed
Apr 26, 2024
| } | ||
|
|
||
| public static void main(String args[]) throws Exception { | ||
| if ((!Platform.isLinux() && !Platform.isOSX()) || !"64".equals(System.getProperty("sun.arch.data.model"))) { |
There was a problem hiding this comment.
Suggested change
| if ((!Platform.isLinux() && !Platform.isOSX()) || !"64".equals(System.getProperty("sun.arch.data.model"))) { | |
| if ((!Platform.isLinux() && !Platform.isOSX()) || Platform.is32bit()) { |
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
reinrich
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downport from PR 1640 (SapMachine21).
Needed fixes for command line handling and adjusted to the old jtreg test lib.
fixes #1550