Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SapMachine (24): Add dt_filesocket #1690

Merged
merged 12 commits into from
Jun 19, 2024

Conversation

schmelter-sap
Copy link
Member

This is a cherry-pick from sapmachine21 plus adjustments for missing include.,

fixes #1611

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@RealCLanger RealCLanger changed the title Implemented dt_filesocket for sapmachine21 SapMachine (24): Add dt_filesocket Jun 8, 2024
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments regarding the make file.

make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

Copy link
Member

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think that's good then 😄

make/modules/jdk.jdwp.agent/Lib.gmk Outdated Show resolved Hide resolved
@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@MBaesken
Copy link
Member

Please fix the typo 'doamin socket' .
Otherwise looks okay to me.

@RealCLanger
Copy link
Member

Please fix the typo 'doamin socket' . Otherwise looks okay to me.

Done.

@SapMachine
Copy link
Member

Hello @schmelter-sap, this pull request fulfills all formal requirements.

@RealCLanger RealCLanger merged commit 1e9c4a0 into SAP:sapmachine Jun 19, 2024
96 of 98 checks passed
RealCLanger pushed a commit to RealCLanger/SapMachine that referenced this pull request Jul 29, 2024
RealCLanger pushed a commit to RealCLanger/SapMachine that referenced this pull request Jul 29, 2024
RealCLanger pushed a commit to RealCLanger/SapMachine that referenced this pull request Jul 29, 2024
RealCLanger pushed a commit that referenced this pull request Jul 30, 2024
RealCLanger pushed a commit that referenced this pull request Jul 30, 2024
RealCLanger pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement dt_filesocket for sapmachine 17+
4 participants