fix: yeoman-environment version update + code refactor + tests #52
Conversation
backend/src/contributors.ts
Outdated
| const contributorId = _.get(uiOptions, "contributorId"); | ||
| const snippetName = _.get(uiOptions, "snippetName"); | ||
| if (contributorId && snippetName) { | ||
| const api = await Contributors.apiMap.get(contributorId); |
There was a problem hiding this comment.
feel to me like there is no await for the activate() method.
There was a problem hiding this comment.
I would like to keep a getApi method.
There was a problem hiding this comment.
extension.activate() returns Thenable, so it is OK to use await
There was a problem hiding this comment.
I have added a new test with activate method
There was a problem hiding this comment.
const apiPromise = Contributors.apiMap.get(contributorId);
const api = await
| Contributors.getSnippet(_.get(uiOptions, "snippet", uiOptions)).then(snippet => { | ||
| if (_.isNil(snippet)) { | ||
| this.webViewPanel.dispose(); | ||
| return vscode.window.showErrorMessage("Can not find snippet."); |
There was a problem hiding this comment.
I consider remove the vscode notification. and only only log it.
There was a problem hiding this comment.
We talked to leave it, didn't we ?
| this.initWebviewPanel(); | ||
| Contributors.getSnippet(_.get(uiOptions, "snippet", uiOptions)).then(snippet => { | ||
| if (_.isNil(snippet)) { | ||
| this.webViewPanel.dispose(); |
backend/src/contributors.ts
Outdated
| const contributorId = _.get(uiOptions, "contributorId"); | ||
| const snippetName = _.get(uiOptions, "snippetName"); | ||
| if (contributorId && snippetName) { | ||
| const api = await Contributors.apiMap.get(contributorId); |
There was a problem hiding this comment.
const apiPromise = Contributors.apiMap.get(contributorId);
const api = await
| } | ||
| } | ||
| private static getApiPromise(extension: vscode.Extension<any>) { | ||
| return (extension.isActive ? extension.exports : extension.activate()); |
There was a problem hiding this comment.
extension.exports is not a promise, but we can keep the name.
|
as we just discuss. lets activate (if not already active) only when trying to get the snippet, and then update the apiMap. |
backend/src/contributors.ts
Outdated
| const extensionName: string = _.get(extension, "packageJSON.name"); | ||
| const extensionPublisher: string = _.get(extension, "packageJSON.publisher"); | ||
| const extensionId = `${extensionPublisher}.${extensionName}`; |
There was a problem hiding this comment.
private static getExtensionId(extension: vscode.Extension)
backend/src/contributors.ts
Outdated
| } | ||
| } | ||
|
|
||
| private static getApiPromise(extension: vscode.Extension<any>) { | ||
| return (extension.isActive ? extension.exports : extension.activate()); | ||
| return (extension.isActive ? Promise.resolve(extension.exports) : extension.activate()); |
There was a problem hiding this comment.
no need to wrap extension.exports with Promise.
| const contributorId = _.get(contributerInfo, "contributorId"); | ||
| const snippetName = _.get(contributerInfo, "snippetName"); | ||
| const extension = Contributors.getContributorExtension(contributorId); | ||
| if (extension) { |
There was a problem hiding this comment.
what if extension not found?
There was a problem hiding this comment.
in this case tab is closed and we show error message
backend/src/contributors.ts
Outdated
| if (!extension.isActive) { | ||
| public static async getSnippet(contributerInfo: any) { | ||
| const contributorId = _.get(contributerInfo, "contributorId"); | ||
| const snippetName = _.get(contributerInfo, "snippetName"); |
There was a problem hiding this comment.
move into the try block
No description provided.