Support For Reading Jobs By Model Name #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedomdom
reviewed
Jan 10, 2022
| for job in jobs: | ||
| if job["modelName"] == model_name: | ||
| return job | ||
| else: # pylint: disable=useless-else-on-loop |
There was a problem hiding this comment.
Do you think it is easier to read the code with the else or why do we need it?
There was a problem hiding this comment.
It works fine without the else. I don't remember why that was added in the first place. Removed. Thanks!
Comment on lines
157
to
158
| job_by_name = model_manager_client.read_job_by_model_name(model_name) | ||
| assert job_by_name is not None |
There was a problem hiding this comment.
Not sure but maybe we can also test the read_job_by_model_name by replacing the lines 146-152 with a call to read_job_by_model_name?
There was a problem hiding this comment.
Yes, that would work! Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks: