Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint no shadow #199

Merged
merged 4 commits into from
Jan 15, 2019
Merged

fix: eslint no shadow #199

merged 4 commits into from
Jan 15, 2019

Conversation

greg-a-smith
Copy link
Contributor

@greg-a-smith greg-a-smith commented Jan 15, 2019 •
edited by bcullman
Loading

Enabled the no-shadow eslint rule and fixed lint errors.

#169

@greg-a-smith greg-a-smith requested a review from a team January 15, 2019 03:41
jbadan
jbadan approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@greg-a-smith greg-a-smith merged commit 5095caa into master Jan 15, 2019
@greg-a-smith greg-a-smith deleted the fix/eslint-no-shadow branch January 15, 2019 20:31
greg-a-smith added a commit that referenced this pull request Mar 5, 2019
@greg-a-smith
fix: eslint no shadow (#199)
0fb5650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

@cjskillingstad cjskillingstad cjskillingstad approved these changes

@mobot11 mobot11 mobot11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg-a-smith @mobot11 @cjskillingstad @jbadan