Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eslint prop-types rules #211

Merged
merged 2 commits into from
Jan 15, 2019
Merged

fix: eslint prop-types rules #211

merged 2 commits into from
Jan 15, 2019

Conversation

cjskillingstad
Copy link
Contributor

@cjskillingstad cjskillingstad commented Jan 15, 2019 •
edited by bcullman
Loading

  • Added two lint rules surrounding react prop types: react/jsx-sort-props, react/prop-types.
  • Fixed errors associated with those rules.

#169

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jbadan
jbadan approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do another commit to force the build on travis, then 🚢

@cjskillingstad cjskillingstad merged commit ec36cb9 into master Jan 15, 2019
@bcullman bcullman deleted the fix/proptype-linting branch January 16, 2019 01:22
greg-a-smith pushed a commit that referenced this pull request Mar 5, 2019
@cjskillingstad
fix: eslint prop-types rules (#211)
95bddb9 
* Add sort props rule

* Proptypes lint rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadan jbadan jbadan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjskillingstad @CLAassistant @jbadan