fix: Prop spreading for Time #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjskillingstad
commented
Jan 16, 2019
cjskillingstad
commented
- Spread props to Time's elements
- Update unit tests
- Update docs
greg-a-smith
suggested changes
Jan 17, 2019
greg-a-smith
suggested changes
Jan 17, 2019
src/Time/Time.Component.js
Outdated
| }, | ||
| { | ||
| name: 'hoursUpButtonProps', | ||
| description: 'object - Additional props to be spread to the Time component\'s hours down button element.' |
There was a problem hiding this comment.
Should be "hours up button"
src/Time/Time.Component.js
Outdated
| }, | ||
| { | ||
| name: 'minutesUpButtonProps', | ||
| description: 'object - Additional props to be spread to the Time component\'s minutes down button element.' |
There was a problem hiding this comment.
Should be "minutes up button"
src/Time/Time.Component.js
Outdated
| }, | ||
| { | ||
| name: 'secondsUpButtonProps', | ||
| description: 'object - Additional props to be spread to the Time component\'s seconds down button element.' |
There was a problem hiding this comment.
Should be "seconds up button"
src/Time/Time.Component.js
Outdated
| }, | ||
| { | ||
| name: 'meridiemUpButtonProps', | ||
| description: 'object - Additional props to be spread to the Time component\'s meridiem down button element.' |
There was a problem hiding this comment.
Should be "meridiem up button"
There was a problem hiding this comment.
Oops, copy/paste mistake. Fixed all of these in 7496561
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Spread props * Update docs * Fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.