Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename dismissable to dismissible in Alert component #235

Merged
merged 2 commits into from
Jan 17, 2019
Merged

fix: rename dismissable to dismissible in Alert component #235

merged 2 commits into from
Jan 17, 2019

Conversation

mobot11
Copy link
Contributor

@mobot11 mobot11 commented Jan 17, 2019

Fixes #234

@mobot11 mobot11 requested a review from a team January 17, 2019 01:57
@mobot11 mobot11 changed the title fix: rename dismissable to dismissible in Alert component feat: rename dismissable to dismissible in Alert component Jan 17, 2019
greg-a-smith
greg-a-smith suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging blocked until fundamental-bot admin rights are restored.

greg-a-smith
greg-a-smith suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two references to the incorrect spelling in Playground.js.

@greg-a-smith
Copy link
Contributor

Minor nit: The PR should be prefixed as fix: rather than feat:.

@mobot11 mobot11 changed the title feat: rename dismissable to dismissible in Alert component fix: rename dismissable to dismissible in Alert component Jan 17, 2019
greg-a-smith
greg-a-smith approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢

@mobot11 mobot11 merged commit ec2dd6f into master Jan 17, 2019
@mobot11 mobot11 deleted the fix/rename-dismissable branch January 17, 2019 20:59
@jbadan jbadan mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-a-smith greg-a-smith greg-a-smith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobot11 @greg-a-smith