-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(odata-service): Removes ui5-config -> odata-service-writer dep #127
Conversation
The net result is that we no longer will attempt to use TS 4.1 types (from yaml) when importing odata-service-writer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me.
missing sap client in getFioriToolsProxyMiddlewareConfig is pre-existing an can create a separate bug for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, the separation of the OdataService type and input required for the ui5-config helps nicely with a clean separation of concerns.
* origin/main: chore: apply latest changesets Fix versions (#146) chore: apply latest changesets Fix missing client in fiori proxy config (#138) fix(odata-service-writer): Reinstate yaml config ordering (#140) chore: apply latest changesets chore: update version pipeline to skip git hooks (#141) chore: update version pipeline to use github PAT (#137) feat: enable changesets and release workflow (#129) fix(odata-service): Dont add mock config if no metadata (#135) refactor: remove common module (#122) Remove redundant code (handlebars values) (#128) fix(odata-service): Removes ui5-config -> odata-service-writer dep (#127) fix(ui5-application-writer): Fix error when running lint task of app (#125) refactor: rm common types module (#123) # Conflicts: # .github/workflows/pipeline.yml # package.json # packages/odata-service-writer/src/index.ts # pnpm-lock.yaml
The net result is that we no longer include the TS 4.1 types (from yaml) when importing odata-service-writer