Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing client in fiori proxy config #138

Merged
merged 7 commits into from
Oct 22, 2021
Merged

Fix missing client in fiori proxy config #138

merged 7 commits into from
Oct 22, 2021

Conversation

devinea
Copy link
Member

@devinea devinea commented Oct 21, 2021

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 1869599

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/fiori-freestyle-writer Minor
@sap-ux/odata-service-writer Minor
@sap-ux/ui5-application-writer Minor
@sap-ux/ui5-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tobiasqueck
Copy link
Contributor

@devinea Can we use a client starting with 0 e.g. 012 for testing to make sure that the 0 is not getting lost accidentally in case some string/int conversions are happing somewhere.

@devinea
Switch to client 012
877a3eb
@devinea
Merge remote-tracking branch 'origin/fix_sap_client' into fix_sap_client
305d5a3 
* origin/fix_sap_client:
  chore: update version pipeline to use github PAT (#137)
@devinea
Copy link
Member Author

devinea commented Oct 21, 2021

Done @tobiasqueck

tobiasqueck
tobiasqueck previously approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the snapshot with my expectation, especially check for the leading 0.

unseen1980
unseen1980 previously approved these changes Oct 21, 2021
View reviewed changes
ullasholla
ullasholla previously requested changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@ullasholla ullasholla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @devinea, thanks.

Does anything related to changesets required to be done?
I think @kranthie-sap updated the README recently: https://github.com/SAP/open-ux-tools/blob/main/README.md#create-changesets-for-feature-or-bug-fix-branches

@kranthie-sap
Copy link
Contributor

@devinea: Yes, please run pnpm cset, select the updated packages, patch bump and add a message for this change. You will then need to push the newly added changeset config files.

@devinea
changeset
ab5e7f2
@devinea
Merge remote-tracking branch 'origin/main' into fix_sap_client
9fe1344 
* origin/main:
  fix(odata-service-writer): Reinstate yaml config ordering (#140)
  chore: apply latest changesets
  chore: update version pipeline to skip git hooks (#141)

# Conflicts:
#	packages/fiori-freestyle-writer/test/__snapshots__/worklist.test.ts.snap
@devinea
Update snapshots
1869599
@devinea devinea dismissed stale reviews from unseen1980 and tobiasqueck via 1869599 October 22, 2021 09:01
@devinea
Copy link
Member Author

devinea commented Oct 22, 2021

Thanks @ullasholla @kranthie-sap - Patch set applied as requested.

@devinea devinea merged commit cd119ea into main Oct 22, 2021
@devinea devinea deleted the fix_sap_client branch October 22, 2021 12:48
devinea added a commit that referenced this pull request Oct 22, 2021
@devinea
Merge remote-tracking branch 'origin/main' into Add_writer_readme_and…
8473d25 
…_npm_ignore

* origin/main:
  chore: apply latest changesets
  Fix versions (#146)
  chore: apply latest changesets
  Fix missing client in fiori proxy config (#138)

# Conflicts:
#	packages/ui5-config/package.json
devinea added a commit that referenced this pull request Oct 23, 2021
@devinea
Merge remote-tracking branch 'origin/main' into integration_test
fa4aaf8 
* origin/main:
  chore: apply latest changesets
  Fix versions (#146)
  chore: apply latest changesets
  Fix missing client in fiori proxy config (#138)
  fix(odata-service-writer): Reinstate yaml config ordering (#140)
  chore: apply latest changesets
  chore: update version pipeline to skip git hooks (#141)
  chore: update version pipeline to use github PAT (#137)
  feat: enable changesets and release workflow (#129)
  fix(odata-service): Dont add mock config if no metadata (#135)
  refactor: remove common module (#122)
  Remove redundant code (handlebars values) (#128)
  fix(odata-service): Removes ui5-config -> odata-service-writer dep (#127)
  fix(ui5-application-writer): Fix error when running lint task of app (#125)
  refactor: rm common types module (#123)

# Conflicts:
#	.github/workflows/pipeline.yml
#	package.json
#	packages/odata-service-writer/src/index.ts
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unseen1980 unseen1980 unseen1980 approved these changes

@tobiasqueck tobiasqueck tobiasqueck approved these changes

@ullasholla ullasholla ullasholla left review comments

@IainSAP IainSAP Awaiting requested review from IainSAP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devinea @tobiasqueck @kranthie-sap @ullasholla @unseen1980