Remove redundant code (handlebars values) #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IainSAP
reviewed
Oct 20, 2021
packages/fiori-freestyle-writer/templates/worklist/add/webapp/Component.js
Outdated
Show resolved
Hide resolved
|
…redundant-code
IainSAP
previously approved these changes
Oct 20, 2021
…ools into fix/redundant-code
tobiasqueck
previously approved these changes
Oct 21, 2021
tobiasqueck
approved these changes
Oct 21, 2021
devinea
approved these changes
Oct 21, 2021
|
Thanks! |
devinea
added a commit
that referenced
this pull request
Oct 23, 2021
* origin/main: chore: apply latest changesets Fix versions (#146) chore: apply latest changesets Fix missing client in fiori proxy config (#138) fix(odata-service-writer): Reinstate yaml config ordering (#140) chore: apply latest changesets chore: update version pipeline to skip git hooks (#141) chore: update version pipeline to use github PAT (#137) feat: enable changesets and release workflow (#129) fix(odata-service): Dont add mock config if no metadata (#135) refactor: remove common module (#122) Remove redundant code (handlebars values) (#128) fix(odata-service): Removes ui5-config -> odata-service-writer dep (#127) fix(ui5-application-writer): Fix error when running lint task of app (#125) refactor: rm common types module (#123) # Conflicts: # .github/workflows/pipeline.yml # package.json # packages/odata-service-writer/src/index.ts # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant handlebars values that are not required anymore. This will help us fix the integration test in Fiori Freestyle generator.