Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable changesets and release workflow #129

Merged
merged 7 commits into from
Oct 21, 2021

Conversation

kranthie-sap
Copy link
Contributor

@kranthie-sap kranthie-sap commented Oct 20, 2021

Changesets and Release Workflow

  • To manage versioning and publishing of modules, changesets has been configured to be run locally by developers.
  • The changeset-bot has been enabled to add comments to PRs when no changesets are found in the PR.
  • The changeset GitHub Action is used in the pipeline to version and publish every commit merged to the main branch.
  • The README.md file has been updated with more information on changesets and the release workflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2021

🦋 Changeset detected

Latest commit: c4b7671

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-config Patch
@sap-ux/yaml Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tobiasqueck
tobiasqueck previously approved these changes Oct 21, 2021
Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated documentation looks good. I am not able to judge whether the configuration is correct or not.

devinea
devinea previously approved these changes Oct 21, 2021
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kranthie-sap. Looks good.

tobiasqueck
tobiasqueck previously approved these changes Oct 21, 2021
devinea
devinea previously approved these changes Oct 21, 2021
@kranthie-sap kranthie-sap dismissed stale reviews from devinea and tobiasqueck via 1b01b8b October 21, 2021 16:00
@kranthie-sap
Copy link
Contributor Author

Merging using admin privileges to test pipeline.

@kranthie-sap kranthie-sap merged commit f6e1223 into main Oct 21, 2021
@kranthie-sap kranthie-sap deleted the chore/enable-changesets-and-release-workflow branch October 21, 2021 16:10
devinea added a commit that referenced this pull request Oct 23, 2021
* origin/main:
  chore: apply latest changesets
  Fix versions (#146)
  chore: apply latest changesets
  Fix missing client in fiori proxy config (#138)
  fix(odata-service-writer): Reinstate yaml config ordering (#140)
  chore: apply latest changesets
  chore: update version pipeline to skip git hooks (#141)
  chore: update version pipeline to use github PAT (#137)
  feat: enable changesets and release workflow (#129)
  fix(odata-service): Dont add mock config if no metadata (#135)
  refactor: remove common module (#122)
  Remove redundant code (handlebars values) (#128)
  fix(odata-service): Removes ui5-config -> odata-service-writer dep (#127)
  fix(ui5-application-writer): Fix error when running lint task of app (#125)
  refactor: rm common types module (#123)

# Conflicts:
#	.github/workflows/pipeline.yml
#	package.json
#	packages/odata-service-writer/src/index.ts
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants