Always escape special chars in URL query params #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 92.63% 92.70% +0.06%
==========================================
Files 6 6
Lines 2675 2672 -3
==========================================
- Hits 2478 2477 -1
+ Misses 197 195 -2
Continue to review full report at Codecov.
|
|
Good catch! Thank you very much. Can you accept the CLA, please? I cannot merge your patch without it. |
Done! |
|
CLA signed, PR looking good. I will update changelog in follow-up commit. |
phanak-sap
added a commit
that referenced
this pull request
Aug 22, 2021
add fix merged from PR #175
|
Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some special URL characters (such as
+,=and&) were not escaped in query parameters. This would introduce a risk of data corruption or URL injection.Note: I did not notice any breakage when testing against SAP. However, I only tested a few use cases (e.g., I barely tested batched requests).