Skip to content

Conversation

RandomByte
Copy link
Member

@RandomByte RandomByte commented Jul 11, 2018

Package sizes (tested by executing npm pack):

Before
npm notice package size: 29.0 kB
npm notice unpacked size: 107.2 kB

After
npm notice package size: 17.8 kB
npm notice unpacked size: 64.2 kB

=> Reduction of ~40%

New package content:

❯ tree                                                       
.
├── CHANGELOG.md
├── CONTRIBUTING.md
├── LICENSE.txt
├── NOTICE.txt
├── README.md
├── index.js
├── jsdoc.json
├── lib
│   ├── AbstractReader.js
│   ├── AbstractReaderWriter.js
│   ├── DuplexCollection.js
│   ├── ReaderCollection.js
│   ├── ReaderCollectionPrioritized.js
│   ├── Resource.js
│   ├── adapters
│   │   ├── AbstractAdapter.js
│   │   ├── FileSystem.js
│   │   └── Memory.js
│   ├── fsInterface.js
│   ├── resourceFactory.js
│   └── tracing
│       ├── Trace.js
│       └── traceSummary.js
└── package.json

@RandomByte RandomByte requested a review from matz3 July 11, 2018 09:23
@coveralls
Copy link

coveralls commented Jul 11, 2018

Pull Request Test Coverage Report for Build 89

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.719%

Totals Coverage Status
Change from base Build 79: 0.0%
Covered Lines: 316
Relevant Lines: 513

💛 - Coveralls

- index.js and lib/ content is required runtime code.
- CONTRIBUTING.md should guide people on where to find the source/
report issues.
- jsdoc.json is required to generate cross-repo API doc for releases
(currently done in SAP/ui5-tooling)
@RandomByte RandomByte merged commit e533d82 into master Jul 11, 2018
@RandomByte RandomByte deleted the define-package-files branch July 11, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants