[INTERNAL] npm translator: Add addtl. test for cyclic dependencies #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavily influenced by 'es6-map' and its dependencies
RandomByte
force-pushed
the
cyclic-deps-episode-2
branch
from
153feb3 to
065a869
Compare
RandomByte
force-pushed
the
cyclic-deps-episode-2
branch
from
065a869 to
0f0f6e0
Compare
matz3
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fixtures heavily influenced by es6-map and its (cyclic-)dependencies: http://npm.broofa.com/?q=es6-map
(excluding event-emitter, next-tick and es6-set)
This scenario used to fail with
Promise returned by test never resolved. With this PR the graph is transformed into a tree with "deduped" nodes as leafs instead of references.Related to https://github.com/SAP/ui5-project/issues/50
Follow up of #53