Skip to content

[FIX] CSP Middleware: Export middleware, add report-uri #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

[FIX] CSP Middleware: Export middleware, add report-uri #25

merged 1 commit into from
Jul 10, 2018

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jul 9, 2018

No description provided.

@matz3 matz3 added the bug label Jul 9, 2018
@matz3 matz3 requested review from codeworrior and domianer July 9, 2018 11:02
@coveralls
Copy link

coveralls commented Jul 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 105

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 72.087%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/middleware/csp.js 4 5 80.0%
Totals Coverage Status
Change from base Build 97: -0.2%
Covered Lines: 224
Relevant Lines: 290
💛 - Coveralls

domianer
domianer approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@domianer domianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matz3 matz3 merged commit 2091c0c into master Jul 10, 2018
@matz3 matz3 deleted the fix-csp-middleware branch July 10, 2018 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeworrior codeworrior Awaiting requested review from codeworrior

1 more reviewer

@domianer domianer domianer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @domianer