Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.m.Carousel creates new sap.m.ScrollContainer without requiring it #55

Closed
1 task
hschaefer123 opened this issue Sep 18, 2018 · 1 comment
Closed
1 task
Assignees
Labels
bug Something isn't working

Comments

@hschaefer123
Copy link

Expected Behavior

self-contained issue using sap.m.Carousel

Current Behavior

missing in self-contained

Steps to reproduce the issue

use carousel inside view

Affected components

{workaround}
require sap.m.ScrollContainer


Regards Holger
@matz3 matz3 self-assigned this Jan 4, 2019
openui5bot pushed a commit to SAP/openui5 that referenced this issue Jan 7, 2019
Change-Id: Icb31eae9e8e56046d4395172a837d783c1a87696
See: SAP/ui5-tooling#55
@matz3
Copy link
Member

matz3 commented Jan 7, 2019

We already have an internal PoC to detect such global dependencies during bundling, but there are some more things to clarify until this could be added to the ui5-builder.
Anyway this would be mainly to support legacy code, as we don't recommend using classes / controls via the global namespace.
That's why I just merged a change to declare the global dependencies as AMD dependencies which will solve this particular issue (SAP/openui5@c739627).

@matz3 matz3 closed this as completed Jan 7, 2019
@matz3 matz3 added the bug Something isn't working label Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants