Add Spec version 2.0 #217
Merged
Add Spec version 2.0 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
approved these changes
Mar 24, 2020
RandomByte
requested changes
Mar 24, 2020
RandomByte
requested changes
Mar 24, 2020
KlattG
reviewed
Mar 25, 2020
There was a problem hiding this comment.
I only checked the green bits and have one suggestion. I expect that users will want to know exactly which versions are backward-compatible and which aren't. If something isn't compatible, it should be listed in the table below the sentence. If you're not sure yourself about the extent of backward-compatibility, don't mention it at all. Please get rid of the "might" - it just confuses the reader.
| @@ -308,13 +308,14 @@ All changes are documented below. | |||
|
|
|||
| ### Compatibility Matrix | |||
|
|
|||
| Unless otherwise noted in the table below, the UI5 Tooling modules are backward compatible in the means that for example UI5 CLI v2.0 will still be able to handle a project that is using Specification Version `1.0`. | |||
| Unless otherwise noted in the table below, the UI5 Tooling modules are backward compatible in the means that for example UI5 CLI v3.0.0 might still be able to handle a project that is using Specification Version `1.0`. | |||
There was a problem hiding this comment.
I'd suggest to modify this sentence as follows:
"Unless otherwise noted in the table below, the UI5 Tooling modules are backward compatible."
There was a problem hiding this comment.
Thanks, we'll change it to match your proposal in a separate Pull Request 👍
RandomByte
pushed a commit
that referenced
this pull request
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.