Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL] Add preliminary guide for v3 migration #608

Merged
merged 6 commits into from Apr 6, 2022
Merged

[INTERNAL] Add preliminary guide for v3 migration #608

merged 6 commits into from Apr 6, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Mar 25, 2022

No description provided.

@matz3 matz3 requested review from codeworrior and ecker March 29, 2022 08:59
@matz3 matz3 requested a review from KlattG April 4, 2022 11:36
KlattG
KlattG suggested changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, otherwise LGTM

docs/updates/migrate-v3.md Outdated Show resolved Hide resolved
docs/updates/migrate-v3.md Outdated Show resolved Hide resolved
docs/updates/migrate-v3.md Outdated Show resolved Hide resolved
matz3 and others added 2 commits April 4, 2022 14:52
@matz3 @KlattG
Apply suggestions from code review
568c732 
Co-authored-by: KlattG <57760635+KlattG@users.noreply.github.com>
@matz3
Apply same suggestion to Builder.md
aa8b33c
@KlattG
Copy link
Contributor

KlattG commented Apr 5, 2022

LGTM

KlattG
KlattG previously approved these changes Apr 5, 2022
View reviewed changes
codeworrior
codeworrior previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 dismissed stale reviews from codeworrior and KlattG via 7eb2369 April 6, 2022 06:52
@matz3 matz3 requested a review from KlattG April 6, 2022 06:57
codeworrior
codeworrior approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@codeworrior codeworrior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEBTM ;-)

ecker
ecker approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ecker ecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@matz3 matz3 merged commit d9433ce into master Apr 6, 2022
@matz3 matz3 deleted the docs-migrate-v3 branch April 6, 2022 07:10
KlattG
KlattG reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlattG KlattG KlattG left review comments

@ecker ecker ecker approved these changes

@codeworrior codeworrior codeworrior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matz3 @KlattG @ecker @codeworrior