Skip to content

fix(ui5-navigation-layout): adjust z-index values #11212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
+40 −4
Merged

fix(ui5-navigation-layout): adjust z-index values #11212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d38d394
fix(ui5-navigation-layout): update z-indexes
LidiyaGeorgieva Mar 28, 2025
3b75908
Merge branch 'main' into SideNavZIndex
s-todorova Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fiori/src/themes/NavigationLayout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

.ui5-nl-header {
z-index: 2;
z-index: 3;
}

.ui5-nl-section {
Expand All @@ -29,7 +29,7 @@

.ui5-nl-aside {
transition: transform 0.3s;
z-index: 1;
z-index: 2;
}

:host([is-phone]) .ui5-nl-aside {
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/src/themes/SideNavigationItemBase.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
position: absolute;
content: "";
inset: var(--_ui5_side_navigation_item_focus_border_offset);
z-index: 2;
z-index: 3;
pointer-events: none;
border-radius: var(--_ui5_side_navigation_item_focus_border_radius);
}
Expand Down Expand Up @@ -253,7 +253,7 @@ and there is an additional border that appears on hover. */
:host([side-nav-collapsed]) .ui5-sn-item:not(.ui5-sn-item-active):not(.ui5-sn-item-no-hover-effect):focus {
width: var(--_ui5_side_navigation_item_collapsed_hover_focus_width);
box-shadow: var(--_ui5_side_navigation_box_shadow);
z-index: 1;
z-index: 2;
padding-inline-end: var(--_ui5_side_navigation_item_collapsed_padding_right);
}

Expand Down
36 changes: 36 additions & 0 deletions packages/fiori/test/pages/NavigationLayout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,42 @@ <h2>Sub Item 2</h2>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</p>
</div>
<div id="contSubitem3" class="contentItem">
<h2>Sub Item 3</h2>
<ui5-table id="table">
<ui5-table-selection-multi id="selection" slot="features" selected="Row1 Row3"></ui5-table-selection-multi>
<!-- playground-fold -->
<ui5-table-header-row slot="headerRow">
<ui5-table-header-cell id="produtCol" width="1fr"><span>Product</span></ui5-table-header-cell>
<ui5-table-header-cell id="supplierCol" width="1fr">Supplier</ui5-table-header-cell>
<ui5-table-header-cell id="dimensionsCol" width="1fr">Dimensions</ui5-table-header-cell>
<ui5-table-header-cell id="weightCol" width="1fr">Weight</ui5-table-header-cell>
<ui5-table-header-cell id="priceCol" width="1fr" horizontal-align="End">Price</ui5-table-header-cell>
</ui5-table-header-row>
<ui5-table-row row-key="Row1">
<ui5-table-cell><ui5-label><b>Notebook Basic 15</b><br>HT-1000</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Very Best Screens</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>30 x 18 x 3 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>4.2</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>956</b> EUR</ui5-label></ui5-table-cell>
</ui5-table-row>
<ui5-table-row row-key="Row2">
<ui5-table-cell><ui5-label><b>Notebook Basic 17</b><br>HT-1001</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Smartcards</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>29 x 17 x 3.1 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>4.5</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>1249</b> EUR</ui5-label></ui5-table-cell>
</ui5-table-row>
<ui5-table-row row-key="Row3">
<ui5-table-cell><ui5-label><b>Notebook Basic 18</b><br>HT-1002</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>Technocom</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label>32 x 21 x 4 cm</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label style="color: #2b7c2b"><b>3.7</b> KG</ui5-label></ui5-table-cell>
<ui5-table-cell><ui5-label><b>29</b> EUR</ui5-label></ui5-table-cell>
</ui5-table-row>
<!-- playground-fold-end -->
</ui5-table>
</div>
</div>
</ui5-navigation-layout>

Expand Down