fix(ui5-li): fix title update when initially empty #2362
Merged
+40
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the textContent is an empty string initially, the following element is not rendered <span part="title" class="ui5-li-title"><slot></slot></span> Later when we update the textContent it is not displayd as it relys on the slotting, but the slot element is not there. The issue has been found in a specific Select use case, referenced below. I considered making a ui5-select-list-item and make that change in a separate template, but I can't find side effects or visual degradations. FIXES #2342
vladitasev
approved these changes
Oct 28, 2020
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
When the textContent is an empty string initially, the following element is not rendered <span part="title" class="ui5-li-title"><slot></slot></span> Later when we update the textContent, it is not displayed as it relies on the slotting, but the slot element is not there. The issue has been found in a specific Select use case, referenced below. I considered making a ui5-select-list-item and make that change in a separate template, but I can't find side effects or visual degradations. FIXES #2342
ilhan007
added a commit
that referenced
this pull request
Nov 19, 2020
When the textContent is an empty string initially, the following element is not rendered <span part="title" class="ui5-li-title"><slot></slot></span> Later when we update the textContent, it is not displayed as it relies on the slotting, but the slot element is not there. The issue has been found in a specific Select use case, referenced below. I considered making a ui5-select-list-item and make that change in a separate template, but I can't find side effects or visual degradations. FIXES #2342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the textContent is an empty string initially, the following element, containing the "slot" for the title text is not rendered:
<span part="title" class="ui5-li-title"><slot></slot></span>Later when we update the "textContent" is not displayed as it relies on the slotting, but the "slot" element is not there.
The issue has been found in a specific Select use case, referenced below. That's why I considered making a "ui5-select-list-item" and make that change in a separate template, but I can't find side effects or visual degradations.
FIXES #2342