Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-li): fix title update when initially empty #2362

Merged
merged 2 commits into from
Oct 28, 2020
Merged

fix(ui5-li): fix title update when initially empty #2362

merged 2 commits into from
Oct 28, 2020

Commits on Oct 15, 2020

  1. fix(ui5-li): fix title update when initially empty 

    When the textContent is an empty string initially, the following element is not rendered
<span part="title" class="ui5-li-title"><slot></slot></span>
Later when we update the textContent it is not displayd as it relys on the slotting, but the slot element is not there. The issue has been found in a specific Select use case, referenced below. I considered making a ui5-select-list-item and make that change in a separate template, but I can't find side effects or visual degradations.

FIXES #2342
    @ilhan007
    ilhan007 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    5097943 View commit details
    Browse the repository at this point in the history

  2. add test

    @ilhan007
    ilhan007 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    95a90e8 View commit details
    Browse the repository at this point in the history