-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-*): use unified API to define a11y attributes via accessibilityAttributes
#8810
refactor(ui5-*): use unified API to define a11y attributes via accessibilityAttributes
#8810
Conversation
accessibilityAttributes
accessibilityAttributes
accessibilityAttributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for team Rodopi components!
Looks good for team Pirin components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the PR description as I assume that some parts are outdated after the last changes. Please inform me once the PR is submitted as we need to update the Accessibility Documentation Chapter after that.
@@ -26,7 +26,6 @@ import ButtonType from "./types/ButtonType.js"; | |||
import ButtonAccessibleRole from "./types/ButtonAccessibleRole.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the ButtonAccessibleRole
enum is no longer needed. We could use the AriaRole
enum now instead. Same applies for the ui5-link component and the corresponding accessibleRole
property. There is the following related PR: https://github.com/SAP/ui5-webcomponents/pull/8807/files
Unifies the API to define additional a11y attributes cross components. The common approach in all relevant components to define additional a11y attributes is via property
accessibilityAttributes
:Fixes: #8353
BREAKING CHANGE:
ui5-flexible-column-layout
accessibilityTexts
accessibilityRoles
accessibilityTexts
andaccessibilityRoles
properties of theui5-flexible-column-layout
are removed.If you have previously used the
accessibilityTexts
oraccessibilityRoles
properties:Now use
accessibilityAttributes
instead:ui5-shellbar
accessibilityTexts
accessibilityRoles
accessibilityTexts
andaccessibilityRoles
properties of theui5-shellbar
are removed.If you have previously used the
accessibilityTexts
oraccessibilityRoles
properties:Now use
accessibilityAttributes
instead:Changes
1. Avatar and AvatarGroup
accessibilityAttributes
property.ariaHasPopup
standalone private property and allow settingaria-haspopup
via the publicaccessibilityAttributes
2. Unified API to define additional a11y attributes
The common approach in all relevant components to define additional a11y attributes is via property
accessibilityAttributes
The
accessibilityAttributes
property is of newly created typeAccessibilityAttributes
, that is describing which attributes are supported and their exact values:3. Fixes
title
property (publictooltip
is available)ariaHasPopup
standalone private property and allow settingaria-haspopup
via the publicaccessibilityAttributes
Don't
Do