Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize pseudoreaction names #39

Merged
merged 2 commits into from
Oct 18, 2015
Merged

Conversation

zakandrewking
Copy link
Contributor

I'm still testing this.

@aebrahim
Copy link
Contributor

Two points

  1. Are we decided on SK_ (I assume short for sink)?
  2. BIOMASS won't have +/- 1 coefficients.

- Standardized names for biomass, sink, exchange, atpm, and demand reactions
- Uses the prefixes EX_, DM_, SK_, BIOMASS_, and ATPM
- If pseudoreactions have gpr's, then log a warning
- If DM_, SK_, or EX_ have coefficients not 1 or -1, then log a warning
- Closes SBRG/bigg_models#84, SBRG/bigg_models#149, SBRG/bigg_models#175
@zakandrewking
Copy link
Contributor Author

  1. I put SK_ in the supplement of the BiGG Models submission, because that was the last we had discussed. These could be called "source/sink reactions" with SK_ representing both.
  2. True, thanks. I fixed the description

For instance, rename EX_glc__D_c to DM_glc__D_c. Previously, this was
just a warning. Also added subsystems "Extracellular exchange",
"Intracellular demand", "Intracellular source/sink", and "Biomass and
maintenance functions".
@zakandrewking
Copy link
Contributor Author

Also added subsystems for pseudoreactions: "Extracellular exchange", "Intracellular demand", "Intracellular source/sink", and "Biomass and maintenance functions".

@zakandrewking
Copy link
Contributor Author

See also SBRG/bigg_models#177

zakandrewking added a commit that referenced this pull request Oct 18, 2015
Standardize pseudoreaction names
@zakandrewking zakandrewking merged commit f17e2d5 into master Oct 18, 2015
@zakandrewking zakandrewking deleted the zk-pseudo-standard branch October 18, 2015 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename exchange reactions to reflect their metabolites
2 participants