Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholding/Automatic Cutoff #1

Merged
merged 9 commits into from
Aug 4, 2020
Merged

Thresholding/Automatic Cutoff #1

merged 9 commits into from
Aug 4, 2020

Conversation

camlam
Copy link
Collaborator

@camlam camlam commented Aug 4, 2020

Hey @avsastry, here is the update for thresholding stuff. Given a couple of people's notes during GA meeting today, I bumped the search space for the cutoff parameter to a max of 2000 instead of 1000. If that ends up being too slow (ran in ~4 minutes on all 229 iModulons of PRECISE 2.0 on my laptop, so it shouldn't be terrible since it should only be necessary once) I can try to make it a bit smarter about only trying larger cutoffs if the best cutoff found is also the largest (i.e. a super crude metric of "is this function still increasing").

@camlam camlam requested a review from avsastry August 4, 2020 01:14
@sapoudel
Copy link
Collaborator

sapoudel commented Aug 4, 2020

For speeding up parameter search, we could start by searching sparsely in large intervals and then narrowing down on the ones that give the best f-scores. It could speed up the processing, but depending on how much the f-score fluctuates we could miss the optimal value.

@avsastry avsastry merged commit 972f092 into master Aug 4, 2020
@avsastry avsastry deleted the thresholding branch August 4, 2020 16:47
jtburrows added a commit that referenced this pull request Aug 22, 2024
Experimental branch - switch upstream to experimental branch updates I performed on SBRG/pymodulon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants