Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @avsastry, here is the update for thresholding stuff. Given a couple of people's notes during GA meeting today, I bumped the search space for the cutoff parameter to a max of 2000 instead of 1000. If that ends up being too slow (ran in ~4 minutes on all 229 iModulons of PRECISE 2.0 on my laptop, so it shouldn't be terrible since it should only be necessary once) I can try to make it a bit smarter about only trying larger cutoffs if the best cutoff found is also the largest (i.e. a super crude metric of "is this function still increasing").