Fix performance regression from overuse of interruption checks #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RubioJr9 @nids2001 Linux users please test this! |
|
I did the latvol test with 100^3 too. It took about 5 minutes on master and 1 second on this branch. |
jessdtate
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't show up on Mac, so I missed it initially. It caused a crazy 300-1000X slow down in ShowField and any algorithm that (over)used the interruption feature using the new future/promise mechanism implemented in #2195, on Windows and Linux. That feature wasn't enabled in the GUI anyway, so I just took out all the checkForInterruption calls until I can figure out a less intrusive way to implement this. Please test and merge ASAP.
For example: ShowField on a 100^3 latvol went from 308 seconds to 1.42 seconds on my i7-10710U.