Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed with MSVC_BATCH and spaces in path #3106

Closed
annchapa opened this issue Mar 16, 2018 · 2 comments
Closed

Build failed with MSVC_BATCH and spaces in path #3106

annchapa opened this issue Mar 16, 2018 · 2 comments

Comments

@annchapa
Copy link

When target dir path has spaces and MSVC_BATCH set to true - cl.exe failed.
Actually it is cl.exe "feature" - Target dir needs to end with slash, not backslash.
In SCons code msvc_output_flag function return '/Fo${TARGET.dir}' + os.sep
Should be '/Fo${TARGET.dir}/'
Here is confirmation https://social.msdn.microsoft.com/Forums/vstudio/en-US/c5992cfc-083a-4472-bf1d-e3151cae2f32/clexe-how-to-setup-path-for-objects-dir-fo-which-contains-spaces?forum=vcgeneral

@bdbaddog
Copy link
Contributor

Can you bring this issue to the scons users mailing list? We prefer that such are discussed there before a bug is filed.
This get's more eyes on the issue, provides workarounds, prevents duplicate bugs, and also invalid bugs from getting files.

@bdbaddog
Copy link
Contributor

Can you create an example to reproduce this? Preferrable a single SConstruct? and/or zip file with a couple source files and an SConstruct?

bdbaddog added a commit that referenced this issue Apr 16, 2018
fix #3106  MSVC handling MSVC_BATCH with targetdir which requires escaping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants