Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3106 MSVC handling MSVC_BATCH with targetdir which requires escaping #3108

Merged
merged 3 commits into from
Apr 16, 2018

Conversation

bdbaddog
Copy link
Contributor

MSVC handling MSVC_BATCH with targetdir which requires escaping.
If the target dir has a space in it and using batch compiles then the

/Fo argument must end with two dirseps
/Fo".]target dir\\"

Fixes Issue #3106

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@coveralls
Copy link

coveralls commented Mar 24, 2018

Coverage Status

Coverage increased (+7.6%) to 66.31% when pulling b42fd7c on bdbaddog:msvcbatch_gh_issue_3106 into e7b15e2 on SCons:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+7.6%) to 66.31% when pulling b42fd7c on bdbaddog:msvcbatch_gh_issue_3106 into e7b15e2 on SCons:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+7.6%) to 66.31% when pulling b42fd7c on bdbaddog:msvcbatch_gh_issue_3106 into e7b15e2 on SCons:master.

@bdbaddog bdbaddog merged commit 832e79a into SCons:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants