Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC detection for 2019, 2017, 2017 Express and 6.0 #3701

Merged
merged 10 commits into from
Jun 21, 2020

Commits on Jun 15, 2020

  1. reset_installed_vcs is setting a local variable named __INSTALLED_VCS…

    …_RUN rather than the changing the global variable. Added global definition.
    jcbrill committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    072bfb6 View commit details
    Browse the repository at this point in the history
  2. The cl.exe existence check for msvc 6.0 fails due to the case sensiti…

    …vity of the filename ("cl.exe" and "CL.EXE"). First check vc_dir/bin/cl.exe and vc_dir/cl.exe for existence. Modify the vc_dir walk to check for existence under the directories rather than testing if cl.exe is in the file list. Existence test is not sensitive to file name case.
    jcbrill committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e9835ea View commit details
    Browse the repository at this point in the history
  3. Msvc 14.1Exp detection raises an UnsupportedVersion exception due to …

    …a missing "14.Exp" key in the _VCVER_TO_VSWHERE_VER dictionary. Add the "14.Exp" to the dictionary.
    jcbrill committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e59880b View commit details
    Browse the repository at this point in the history
  4. The order of results from the vswhere query using "products *" is unr…

    …eliable when multiple versions of msvc are installed. Modify the vswhere queries by version to detect the appropriate products: 14.2 [default, BuildTools], 14.1 [default, BuildTools], 14.1Exp [WDExpress]. The default is Enterprise, Professional, Community. The order is unknown. With only Build Tools installed, 14.2 and 14.1 require two calls to vswhere.
    jcbrill committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    0d7249d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4299673 View commit details
    Browse the repository at this point in the history
  6. don't exit immediately when vswhere returns no information since ther…

    …e may be more iterations (artifact from moving the vswhere query in a loop)
    jcbrill committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    c23d2aa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ca8292c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Configuration menu
    Copy the full SHA
    df223dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    561d30f View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    86508e0 View commit details
    Browse the repository at this point in the history