Fix ICC profile, buffer and AVIF encoding memory leak #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er with `CFDataCreateWithBytesNoCopy` may fail on some cases Always copy the data buffer via `CFDataCreate`
dreampiggy
commented
Aug 11, 2022
This was referenced Aug 11, 2022
Closed
dreampiggy
force-pushed
the
fix_copy_data_buffer_threads
branch
from
ed6e24f to
a438aed
Compare
This because of some error handle does not release the buffer
dreampiggy
force-pushed
the
fix_copy_data_buffer_threads
branch
from
a438aed to
d5b9708
Compare
This was
linked to
issues
Aug 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the 3 issues @wensbo reported
CFDataCreateWithBytesNoCopyfor ICC Profile cause issue because of ColorSync cache systemfreeon null pointer in error handing cause crashavifImage