Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix animated avif decode failed, os_unfair_lock crash #47

Merged
merged 1 commit into from Jan 30, 2023
Merged

fix animated avif decode failed, os_unfair_lock crash #47

merged 1 commit into from Jan 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2023

No description provided.

@dreampiggy
Copy link
Collaborator

dreampiggy commented Jan 30, 2023 •
edited
Loading

这种类似问题见过2次了……
感觉这个库可以依赖SDWebImage那个私有宏，@onExit，保证所有提前退出的语句都有析构

或者使用goto来做统一的error cleanup

@dreampiggy dreampiggy merged commit b320094 into SDWebImage:master Jan 30, 2023
@dreampiggy
Copy link
Collaborator

先临时合了这个问题，然后Clang Analyzer发现了另一个memory问题，均已修复
https://github.com/SDWebImage/SDWebImageAVIFCoder/releases/tag/0.9.5

@ghost
Copy link
Author

ghost commented Jan 30, 2023

这种类似问题见过2次了…… 感觉这个库可以依赖SDWebImage那个私有宏，@onExit，保证所有提前退出的语句都有析构

或者使用goto来做统一的error cleanup

今天刚上班，看见上个星期每天崩了 4000 次，今天修了一下。也注意到了@onexit，看见场景不多就没用，后面注意

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dreampiggy @iatbowen