AnimatedImage not resizable

[maundytime]

AnimatedImage seems not resizable, always stretched.
WebImage aspectRatio() works well.

When they are embedded in List, after scrolling out and in, AnimatedImage size would change to its image original size.

[dreampiggy]

This is the Known issue. Since the AnimatedImage is backing UIKit View SDAnimatedImageView. The time when I written the first version, there are no any Public API in Swift UI, to response for the resizable modifier of View protocol. So the SDAnimatedImageView can not set any aspect fit changes.

I'll have a check again if there are new API available. And PR is welcomed if you have knowledge for this.

[dreampiggy]

See this line: https://github.com/SDWebImage/SDWebImageSwiftUI/blob/master/Example/SDWebImageSwiftUIDemo/ContentView.swift#L21

[dreampiggy]

I've add two scaleToFit() and scaleToFill() method on AnimatedImage. Maybe this should help with it.

Released v0.1.1

[maundytime]

Worked when not in a scrolling List. Size still become real image size from the frame size when in list and scrolling. I would give feedback if any solutions found.

[dreampiggy]

Can you help to provide your demo, so that we can use that to debug and investigate.

[maundytime]

https://github.com/maundytime/Demo
When scrolling the AnimatedImage out of screen and scrolling back, the image size changed to it original image size.

I did more test with SDWebImage and YYWebImage on newest commit, they appear as stretched by default at first, and both change the size when cell re-enter screen, but in different ways. Not sure whether it is SDWebImage issue or SDWebImageSwiftUI issue.

[dreampiggy]

Seems Apple's issue of SwiftUI layout engine. There is no method call to triger frame change inside SDAnimatedImageView or YYAnimatedImageView themselves.

When scrolling outside, both of them will receive a setFrame call from SwiftUI layout engine. But the size is wrong and to be the image.size

Why you look the size different, because SDAnimatedImageView, or SDWebImage, follows the correct scale factor of your URL. This URL image size is treat as 1x because it does not have @2x.png in URL string. (480x258). And you can always specify a custom scale factor using context option .imageScaleFactor = 2 for controlling this. See documentation

However , YYImage treat it as 2x, which result in (240x129), but this is totally wrong and considered to be a bug. No any information for them to detect this sacle factor value, right ? But sadly YYImage is no longer manitained by anyone...

[dreampiggy]

[dreampiggy]

Maybe this need a workaround, to override the updateUIView method in AnimatedImage ? And refresh the UIView.frame ?

[dreampiggy]

@maundytime It seems SwiftUI's Image struct has a method resizable(capInsets:resizingMode:). This method will cause the image to be sizable by .frame modifier.

If you use Image without that resizable, you will face the exact same issue as custom UIViewPresentable.

See my result test: