Upgrade the dependency to SDWebImage 5.7, supports the maxFileSize encoding options, as well as enabling the thread-encoding for speedup #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding options, as well as enabling the thread-encoding for speedup
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 82.92% 82.51% -0.41%
==========================================
Files 2 2
Lines 732 755 +23
==========================================
+ Hits 607 623 +16
- Misses 125 132 +7
Continue to review full report at Codecov.
|
radko93
added a commit
to radko93/react-native-fast-image
that referenced
this pull request
Apr 28, 2020
This enabled multi-thread encoding for improved performance. Also, `SDWebImage` 5.7 seems to be required SDWebImage/SDWebImageWebPCoder#35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See 5.7.0 feature: maxFileSize
libwebp Encoding API: https://developers.google.com/speed/webp/docs/api#advanced_encoding_api